Skip to content

[Logger] fix: logger name in child loggers - #3733

Merged
dnechay merged 2 commits into
developfrom
dnechay/fix-logger-child
Jan 5, 2026
Merged

[Logger] fix: logger name in child loggers#3733
dnechay merged 2 commits into
developfrom
dnechay/fix-logger-child

Conversation

@dnechay

@dnechay dnechay commented Jan 5, 2026

Copy link
Copy Markdown
Collaborator

Issue tracking

Freestyle

Context behind the change

Atm if you create a child logger w/o any name, then existing name isn't kept in bindings, e.g.

import logger from '../src';

// to log simple message
logger.info('Info without any context');

const child = logger.child({ binding: 15 })
child.info('hello from first child');

you will have next output (child logger doesn't have name in it, but it's expected)
Screenshot 2026-01-05 at 14 12 03

Here we fix it to get correct name binding
Screenshot 2026-01-05 at 14 13 02

Also made name public just for convenience.

How has this been tested?

  • locally using basic.ts script w/ child logger (see screenshots above)

Release plan

Merge & release new package version

Potential risks; What to monitor; Rollback plan

No

@vercel

vercel Bot commented Jan 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
human-app Ready Ready Preview, Comment Jan 5, 2026 11:13am
human-dashboard-frontend Ready Ready Preview, Comment Jan 5, 2026 11:13am
staking-dashboard Ready Ready Preview, Comment Jan 5, 2026 11:13am
2 Skipped Deployments
Project Deployment Review Updated (UTC)
faucet-frontend Ignored Ignored Jan 5, 2026 11:13am
faucet-server Ignored Ignored Jan 5, 2026 11:13am

@dnechay dnechay self-assigned this Jan 5, 2026
@dnechay dnechay moved this to In Review in Core-tech - 2025 Jan 5, 2026
@dnechay
dnechay requested a review from flopez7 January 5, 2026 11:14
@dnechay dnechay mentioned this pull request Jan 5, 2026
21 tasks
@dnechay
dnechay merged commit 7ded32b into develop Jan 5, 2026
12 checks passed
@github-project-automation github-project-automation Bot moved this from In Review to Done in Core-tech - 2025 Jan 5, 2026
@dnechay
dnechay deleted the dnechay/fix-logger-child branch January 5, 2026 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants